Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update loading test for JS SDK IDB change #12552

Merged
merged 1 commit into from
Feb 27, 2020
Merged

Update loading test for JS SDK IDB change #12552

merged 1 commit into from
Feb 27, 2020

Conversation

jryans
Copy link
Collaborator

@jryans jryans commented Feb 27, 2020 •
edited
Loading

@jryans jryans requested a review from a team February 27, 2020 15:00
@jryans
Copy link
Collaborator Author

jryans commented Feb 27, 2020

This is currently failing because we're missing support for matching branches in CI (#12553). Should be resolved soonish.

bwindels
bwindels approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@bwindels bwindels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jryans jryans merged commit 6bc79ad into develop Feb 27, 2020
@t3chguy t3chguy deleted the jryans/safari-e2e-idb branch May 12, 2022 09:07
t3chguy pushed a commit that referenced this pull request Oct 17, 2024
@richvdh
Add seedrandom dep to resolutions (#12552)
bc48fe4 
* Move seedrandom dep to `resolutions`

... to shut renovate up

* Reinstate `seedrandom` as dev dependency

If we just declare it in `resolutions`, it doesn't get installed at all,
because it is only a devDependency of `bloom-filters`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwindels bwindels bwindels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jryans @bwindels